Add front-sticky property to read-only text in REPL #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that you can't insert new text inside read-only text.
Contributor
|
Is #876 related? |
Contributor
|
Ill merge this tomorrow, unless somebody else chimes in with comments. The |
Contributor
Author
|
I don't think so. It affected the spacemacs guys though (#895). |
Contributor
|
One annoying thing related to read-only text in REPL is that if I yank output of invoked command and paste it as input for next command I can't modify it, and removing readonly text property is a headache (I guess there could be some silly solution which I'm not aware of). |
Contributor
Author
|
Shouldn't you be able to modify yanked read-only text? I'm able to with these changes. Also I found this: which includes the read-only property. |
gracjan
added a commit
that referenced
this pull request
Feb 10, 2016
Add front-sticky property to read-only text in REPL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that you can't insert new text inside read-only text.
This doesn't feel like the best way of doing it (namely the prompt-specific part), but the other ways that I could think of would need an overhaul of the system or they resulted in surprisingly hard to debug errors, so I just settled on this.
The main reason for this is to prevent people from inserting behind the read-only space at the end of the default prompt and wondering why they can't hit RET to evaluate their input (which happened to me enough times).